Forum Discussion

Keyser_Soze's avatar
Keyser_Soze
Contributor
10 months ago

Edit member properties in Bulk

I need to update the properties (Constraints/Texts) of 20.000 UD members based on transformation rules.  The script runs in 10 seconds, but once I add the 'SaveMemberInfo' method it surpasses 2h .....
Metadata
  • NicolasArgente's avatar
    NicolasArgente
    10 months ago

    Hi Keyser_Soze !
    Updating members can be risky - but you already know that.
    Regarding the time it takes, it is normal as it is a Brapi and it will do 20 000 connections to the database.
    Now, for testing purposes you could test with Parralle for Each  and something like this : 

    Imports System.Threading.Tasks

' Assuming ListofU1Stores is a list or collection that supports parallel iteration
Parallel.ForEach(ListofU1Stores, Sub(oStore)
                                     ' Assume these API calls are thread-safe and can be called concurrently
                                     Dim objWritableMember As WritableMember = BRApi.Finance.Members.ReadWritableMemberNoCache(si, DimType.UD1.Id, oStore.Member.Name)
                                     Dim objVaryingMemberProperties As VaryingMemberProperties = BRApi.Finance.Members.ReadMemberPropertiesNoCache(si, DimType.UD1.Id, oStore.Member.Name)

                                     Dim StoreUDVMInfo As UDVMProperties = objVaryingMemberProperties.GetUDProperties()

                                     StoreUDVMInfo.Text1.SetStoredValue(ScenarioType.Unknown.Id, DimConstants.Unknown, text1ToAssign)
                                     StoreUDVMInfo.Text2.SetStoredValue(ScenarioType.Unknown.Id, DimConstants.Unknown, text2ToAssign)

                                     BRApi.Finance.MemberAdmin.SaveMemberInfo(si, True, objWritableMember, True, objVaryingMemberProperties, False, Nothing, TriStateBool.FalseValue)
                                 End Sub)

    I am not an expert of the drawbacks of parallel for each.
    Cheers

NicolasArgente's avatar
NicolasArgente
Valued Contributor

Hi Keyser_Soze !
Updating members can be risky - but you already know that.
Regarding the time it takes, it is normal as it is a Brapi and it will do 20 000 connections to the database.
Now, for testing purposes you could test with Parralle for Each  and something like this : 

Imports System.Threading.Tasks

' Assuming ListofU1Stores is a list or collection that supports parallel iteration
Parallel.ForEach(ListofU1Stores, Sub(oStore)
                                     ' Assume these API calls are thread-safe and can be called concurrently
                                     Dim objWritableMember As WritableMember = BRApi.Finance.Members.ReadWritableMemberNoCache(si, DimType.UD1.Id, oStore.Member.Name)
                                     Dim objVaryingMemberProperties As VaryingMemberProperties = BRApi.Finance.Members.ReadMemberPropertiesNoCache(si, DimType.UD1.Id, oStore.Member.Name)

                                     Dim StoreUDVMInfo As UDVMProperties = objVaryingMemberProperties.GetUDProperties()

                                     StoreUDVMInfo.Text1.SetStoredValue(ScenarioType.Unknown.Id, DimConstants.Unknown, text1ToAssign)
                                     StoreUDVMInfo.Text2.SetStoredValue(ScenarioType.Unknown.Id, DimConstants.Unknown, text2ToAssign)

                                     BRApi.Finance.MemberAdmin.SaveMemberInfo(si, True, objWritableMember, True, objVaryingMemberProperties, False, Nothing, TriStateBool.FalseValue)
                                 End Sub)

I am not an expert of the drawbacks of parallel for each.
Cheers

Keyser_Soze's avatar
Keyser_Soze
Contributor
10 months ago

Thanks for your time, I will definitely try this out !

I did a very dumb attempt, and it worked magically. I switched the 'TriStateBool' => 'TrueValue' and 'SaveMember' => 'False, now from 2h I went down to 4min30 !

I couldn't believe my eyes, so I'm still searching if there are no drawbacks to it. At first I thought it would be slower, since we're indicating with 'TriStateBool' that it's a newly added member. To my surprise, it works faster

  • NicolasArgente's avatar
    NicolasArgente
    Valued Contributor
    10 months ago

    Please can you ask a colleague to check on his UI what he sees after the update. I think I had a mis-adventure in the past with that. I think it was updating on my screen, but not saved. My colleague did not see the changes on his window 🙂
    Have fun 🙂