At this point, my opinion is that this decision is purely customer driven as they will be responsible for maintaining the rules and member formulas post go-live. I would guess that there are currently far more OneStream consultants with VB.net experience than C# experience so that may be a factor in your decision, but I also know that free online converters could help in those situations.
The deprecation of VB.net may or may not happen and when/if it does, will it be in three, five, ten years? We went through the deprecation of Silverlight in 2021 and we successfully navigated that change with our customers.